summaryrefslogtreecommitdiff
path: root/sys/src/9/mtx
diff options
context:
space:
mode:
authorcinap_lenrek <cinap_lenrek@felloff.net>2017-11-04 20:08:22 +0100
committercinap_lenrek <cinap_lenrek@felloff.net>2017-11-04 20:08:22 +0100
commit24057fd4f494a00573d34adeaa7042721c1a06a0 (patch)
treeca69cfd03461c148c60ba0137d20b93976f61b61 /sys/src/9/mtx
parent04ce485f1b4453335db70b4a1b5d2c96458db3c1 (diff)
kernel: introduce per process FPU struct (PFPU) for more flexible machine specific fpu handling
introducing the PFPU structue which allows the machine specific code some flexibility on how to handle the FPU process state. for example, in the pc and pc64 kernel, the FPsave structure is arround 512 bytes. with avx512, it could grow up to 2K. instead of embedding that into the Proc strucutre, it is more effective to allocate it on first use of the fpu, as most processes do not use simd or floating point in the first place. also, the FPsave structure has special 16 byte alignment constraint, which further favours dynamic allocation. this gets rid of the memmoves in pc/pc64 kernels for the aligment. there is also devproc, which is now checking if the fpsave area is actually valid before reading it, avoiding debuggers to see garbage data. the Notsave structure is gone now, as it was not used on any machine.
Diffstat (limited to 'sys/src/9/mtx')
-rw-r--r--sys/src/9/mtx/dat.h33
-rw-r--r--sys/src/9/mtx/main.c2
-rw-r--r--sys/src/9/mtx/trap.c2
3 files changed, 16 insertions, 21 deletions
diff --git a/sys/src/9/mtx/dat.h b/sys/src/9/mtx/dat.h
index 76bb8c856..8b74eb439 100644
--- a/sys/src/9/mtx/dat.h
+++ b/sys/src/9/mtx/dat.h
@@ -1,11 +1,11 @@
typedef struct Conf Conf;
typedef struct Confmem Confmem;
typedef struct FPsave FPsave;
+typedef struct PFPU PFPU;
typedef struct ISAConf ISAConf;
typedef struct Label Label;
typedef struct Lock Lock;
typedef struct Mach Mach;
-typedef struct Notsave Notsave;
typedef struct Page Page;
typedef struct PCArch PCArch;
typedef struct Pcidev Pcidev;
@@ -46,16 +46,6 @@ struct Label
};
/*
- * Proc.fpstate
- */
-enum
-{
- FPinit,
- FPactive,
- FPinactive,
-};
-
-/*
* This structure must agree with fpsave and fprestore asm routines
*/
struct FPsave
@@ -70,6 +60,19 @@ struct FPsave
};
};
+struct PFPU
+{
+ int fpstate;
+ FPsave fpsave[1];
+};
+
+enum
+{
+ FPinit,
+ FPactive,
+ FPinactive,
+};
+
struct Confmem
{
ulong base;
@@ -103,14 +106,6 @@ struct PMMU
int mmupid;
};
-/*
- * things saved in the Proc structure during a notify
- */
-struct Notsave
-{
- ulong UNUSED;
-};
-
#include "../port/portdat.h"
/*
diff --git a/sys/src/9/mtx/main.c b/sys/src/9/mtx/main.c
index 0b1f3401c..4cc7724d9 100644
--- a/sys/src/9/mtx/main.c
+++ b/sys/src/9/mtx/main.c
@@ -241,7 +241,7 @@ procsave(Proc *p)
{
if(p->fpstate == FPactive){
if(p->state != Moribund)
- fpsave(&up->fpsave);
+ fpsave(up->fpsave);
p->fpstate = FPinactive;
}
}
diff --git a/sys/src/9/mtx/trap.c b/sys/src/9/mtx/trap.c
index d9f827216..17c2b7e3d 100644
--- a/sys/src/9/mtx/trap.c
+++ b/sys/src/9/mtx/trap.c
@@ -246,7 +246,7 @@ trap(Ureg *ureg)
up->fpstate = FPactive;
break;
case FPinactive:
- fprestore(&up->fpsave);
+ fprestore(up->fpsave);
up->fpstate = FPactive;
break;
default: