diff options
| author | cinap_lenrek <cinap_lenrek@gmx.de> | 2012-10-01 02:52:05 +0200 |
|---|---|---|
| committer | cinap_lenrek <cinap_lenrek@gmx.de> | 2012-10-01 02:52:05 +0200 |
| commit | 9e7ecc41d56148866725e26c872909823d515963 (patch) | |
| tree | deade257be67db80e2f6f49323cc8dd56fcb370d /sys/src/9/port/auth.c | |
| parent | 347ac6ef58d82e714358935568abcffd3509cfe8 (diff) | |
devproc buffer overflow, strncpy
in devproc status read handler the p->status, p->text and p->user
could overflow the local statbuf buffer as they where copied into
it with code like: memmove(statbuf+someoff, p->text, strlen(p->text)).
now using readstr() which will truncate if the string is too long.
make strncpy() usage consistent, make sure results are always null
terminated.
Diffstat (limited to 'sys/src/9/port/auth.c')
| -rw-r--r-- | sys/src/9/port/auth.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/src/9/port/auth.c b/sys/src/9/port/auth.c index 6c4bdac98..2c8e8a34d 100644 --- a/sys/src/9/port/auth.c +++ b/sys/src/9/port/auth.c @@ -148,7 +148,7 @@ hostdomainwrite(char *a, int n) if(!iseve()) error(Eperm); - if(n >= DOMLEN) + if(n <= 0 || n >= DOMLEN) error(Ebadarg); memset(buf, 0, DOMLEN); strncpy(buf, a, n); |