diff options
| author | cinap_lenrek <cinap_lenrek@centraldogma> | 2011-08-15 18:27:30 +0200 |
|---|---|---|
| committer | cinap_lenrek <cinap_lenrek@centraldogma> | 2011-08-15 18:27:30 +0200 |
| commit | b39d5fbbef72a66288d0a402a76ec9348a3facc0 (patch) | |
| tree | 21647850ddaf9d61881e965c7a86ef4a86199cac /sys/src/9/port/devshr.c | |
| parent | e1318e0bef899022aaef65ad23ddc15e8d79192c (diff) | |
devshr: security!
Diffstat (limited to 'sys/src/9/port/devshr.c')
| -rw-r--r-- | sys/src/9/port/devshr.c | 28 |
1 files changed, 22 insertions, 6 deletions
diff --git a/sys/src/9/port/devshr.c b/sys/src/9/port/devshr.c index 90c6ad781..3aa604ea0 100644 --- a/sys/src/9/port/devshr.c +++ b/sys/src/9/port/devshr.c @@ -392,6 +392,8 @@ shropen(Chan *c, int omode) devpermcheck(shr->owner, shr->perm, openmode(omode)); break; case Qcmpt: + if(omode&OTRUNC) + error(Eexist); shr = sch->shr; mpt = sch->mpt; devpermcheck(mpt->owner, mpt->perm, openmode(omode)); @@ -430,6 +432,12 @@ shrcreate(Chan *c, char *name, int omode, ulong perm) default: error(Enocreate); case Qcroot: + case Qcshr: + if(strcmp(up->user, "none") == 0) + error(Eperm); + } + switch(sch->level){ + case Qcroot: if((perm & DMDIR) == 0 || openmode(omode) != OREAD) error(Eperm); @@ -461,11 +469,14 @@ shrcreate(Chan *c, char *name, int omode, ulong perm) sch->shr = shr; break; case Qcshr: - shr = sch->shr; - devpermcheck(shr->owner, shr->perm, ORDWR); if((perm & DMDIR) || openmode(omode) != OWRITE) error(Eperm); + shr = sch->shr; + if(strcmp(shr->owner, eve) == 0 && !iseve()) + error(Eperm); + devpermcheck(shr->owner, shr->perm, ORDWR); + h = &shr->umh; wlock(&h->lock); if(waserror()){ @@ -520,8 +531,16 @@ shrremove(Chan *c) default: error(Eperm); case Qcshr: + case Qcmpt: shr = sch->shr; - devpermcheck(shr->owner, shr->perm, ORDWR); + if(!iseve()){ + if(strcmp(shr->owner, eve) == 0) + error(Eperm); + devpermcheck(shr->owner, shr->perm, ORDWR); + } + } + switch(sch->level){ + case Qcshr: h = &shr->umh; qlock(&shrslk); rlock(&h->lock); @@ -541,8 +560,6 @@ shrremove(Chan *c) qunlock(&shrslk); break; case Qcmpt: - shr = sch->shr; - devpermcheck(shr->owner, shr->perm, ORDWR); mpt = sch->mpt; m = &mpt->m; h = &shr->umh; @@ -630,7 +647,6 @@ shrwstat(Chan *c, uchar *dp, int n) wunlock(&h->lock); break; } - return n; } |