diff options
| author | cinap_lenrek <cinap_lenrek@felloff.net> | 2020-05-02 17:32:01 +0200 |
|---|---|---|
| committer | cinap_lenrek <cinap_lenrek@felloff.net> | 2020-05-02 17:32:01 +0200 |
| commit | ac88ce4f7f19be1aae1fdf390fa870b4be8dc3f5 (patch) | |
| tree | 47df6acf41dd8d2dc607b89af9d4667935d0c952 /sys/src/cmd/ndb | |
| parent | 7ff6ea0f70307d4b82e6df69eb1310a6e27aa4ad (diff) | |
make bind(2) error handling consistent
The mount() and bind() syscalls return -1 on error,
and the mountid sequence number on success.
The manpage states that the mountid sequence number
is a positive integer, but the kernels implementation
currently uses a unsigned 32-bit integer and does not
guarantee that the mountid will not become negative.
Most code just cares about the error, so test for
the -1 error value only.
Diffstat (limited to 'sys/src/cmd/ndb')
| -rw-r--r-- | sys/src/cmd/ndb/cs.c | 4 | ||||
| -rw-r--r-- | sys/src/cmd/ndb/dns.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/sys/src/cmd/ndb/cs.c b/sys/src/cmd/ndb/cs.c index c508ee1a2..bb85080d4 100644 --- a/sys/src/cmd/ndb/cs.c +++ b/sys/src/cmd/ndb/cs.c @@ -310,7 +310,7 @@ mountinit(char *service, char *mntpt) * put ourselves into the file system */ close(p[0]); - if(mount(p[1], -1, mntpt, MAFTER, "") < 0) + if(mount(p[1], -1, mntpt, MAFTER, "") == -1) error("mount failed"); _exits(0); } @@ -1675,7 +1675,7 @@ err: qunlock(&mountlock); return -1; } - if(mount(fd, -1, mntpt, MAFTER, "") < 0){ + if(mount(fd, -1, mntpt, MAFTER, "") == -1){ close(fd); goto err; } diff --git a/sys/src/cmd/ndb/dns.c b/sys/src/cmd/ndb/dns.c index 3a88facec..692246d04 100644 --- a/sys/src/cmd/ndb/dns.c +++ b/sys/src/cmd/ndb/dns.c @@ -266,7 +266,7 @@ mountinit(char *service, char *mntpt) /* * put ourselves into the file system */ - if(mount(p[1], -1, mntpt, MAFTER, "") < 0) + if(mount(p[1], -1, mntpt, MAFTER, "") == -1) fprint(2, "dns mount failed: %r\n"); _exits(0); } |