From ac88ce4f7f19be1aae1fdf390fa870b4be8dc3f5 Mon Sep 17 00:00:00 2001 From: cinap_lenrek Date: Sat, 2 May 2020 17:32:01 +0200 Subject: make bind(2) error handling consistent The mount() and bind() syscalls return -1 on error, and the mountid sequence number on success. The manpage states that the mountid sequence number is a positive integer, but the kernels implementation currently uses a unsigned 32-bit integer and does not guarantee that the mountid will not become negative. Most code just cares about the error, so test for the -1 error value only. --- sys/src/cmd/5e/5e.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'sys/src/cmd/5e/5e.c') diff --git a/sys/src/cmd/5e/5e.c b/sys/src/cmd/5e/5e.c index 85367c3ee..b91a083ea 100644 --- a/sys/src/cmd/5e/5e.c +++ b/sys/src/cmd/5e/5e.c @@ -23,9 +23,9 @@ dump(void) static void adjustns(void) { - if(bind("/arm/bin", "/bin", MREPL) < 0) + if(bind("/arm/bin", "/bin", MREPL) == -1) sysfatal("bind: %r"); - if(bind("/rc/bin", "/bin", MAFTER) < 0) + if(bind("/rc/bin", "/bin", MAFTER) == -1) sysfatal("bind: %r"); putenv("cputype", "arm"); putenv("objtype", "arm"); -- cgit v1.2.3