From ac88ce4f7f19be1aae1fdf390fa870b4be8dc3f5 Mon Sep 17 00:00:00 2001 From: cinap_lenrek Date: Sat, 2 May 2020 17:32:01 +0200 Subject: make bind(2) error handling consistent The mount() and bind() syscalls return -1 on error, and the mountid sequence number on success. The manpage states that the mountid sequence number is a positive integer, but the kernels implementation currently uses a unsigned 32-bit integer and does not guarantee that the mountid will not become negative. Most code just cares about the error, so test for the -1 error value only. --- sys/src/cmd/aux/timesync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sys/src/cmd/aux/timesync.c') diff --git a/sys/src/cmd/aux/timesync.c b/sys/src/cmd/aux/timesync.c index 6ee46118d..71370d45e 100644 --- a/sys/src/cmd/aux/timesync.c +++ b/sys/src/cmd/aux/timesync.c @@ -303,7 +303,7 @@ main(int argc, char **argv) fd = open(timeserver, ORDWR); if(fd < 0) sysfatal("opening %s: %r", timeserver); - if(amount(fd, "/n/boot", MREPL, "") < 0) + if(amount(fd, "/n/boot", MREPL, "") == -1) sysfatal("mounting %s: %r", timeserver); close(fd); break; -- cgit v1.2.3