From 84c40fb226e374efe05bb7d7eaa4f43f713f4929 Mon Sep 17 00:00:00 2001 From: cinap_lenrek Date: Sun, 21 Sep 2014 19:24:38 +0200 Subject: devip: sanity check Nchan in Fsproto() devip can only handle Maskconv+1 conversations per protocol depending on how many bits it uses in the qid to encode the conversation number. we check this when the protocol gets registered. if we do not do this, the kernel will mysteriously panic when the conversaion numbers collide which took some time to debug. --- sys/src/9/ip/devip.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'sys/src') diff --git a/sys/src/9/ip/devip.c b/sys/src/9/ip/devip.c index 38ba0f81c..e63a4f5ba 100644 --- a/sys/src/9/ip/devip.c +++ b/sys/src/9/ip/devip.c @@ -1243,6 +1243,10 @@ Fsproto(Fs *f, Proto *p) p->qid.type = QTDIR; p->qid.path = QID(f->np, 0, Qprotodir); + if(p->nc > Maskconv+1){ + print("Fsproto: %s nc %d > %d\n", p->name, p->nc, Maskconv+1); + p->nc = Maskconv+1; + } p->conv = malloc(sizeof(Conv*)*(p->nc+1)); if(p->conv == nil) panic("Fsproto"); -- cgit v1.2.3