diff options
| author | Ori Bernstein <ori@eigenstate.org> | 2020-08-10 19:35:05 -0700 |
|---|---|---|
| committer | Ori Bernstein <ori@eigenstate.org> | 2020-08-10 19:35:05 -0700 |
| commit | 1e315f896d9496e22546304ef8b2de74b9451fc4 (patch) | |
| tree | de758c2de4cc725a6c0b74fe5d610615c86fa536 | |
| parent | c834f535b799e0087d74103e96ddb03df457c597 (diff) | |
aux/ms2, aux/na: fix warnings
aux/na was comparing the return of putc with <0, when it should
have been comparing against EOF, which is not specified as -ve.
aux/ms2 was zero-extending the mask for the address when it
should have been sign extended.
| -rw-r--r-- | sys/src/cmd/aux/ms2.c | 2 | ||||
| -rw-r--r-- | sys/src/cmd/aux/na/na.y | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/sys/src/cmd/aux/ms2.c b/sys/src/cmd/aux/ms2.c index 38ba774d4..be30fbf66 100644 --- a/sys/src/cmd/aux/ms2.c +++ b/sys/src/cmd/aux/ms2.c @@ -18,7 +18,7 @@ int binary; int halfswap; int srec = 2; uvlong addr; -ulong psize = 4096; +uvlong psize = 4096; Biobuf stdout; Fhdr exech; Biobuf *bio; diff --git a/sys/src/cmd/aux/na/na.y b/sys/src/cmd/aux/na/na.y index 6350186d7..adb27b8fc 100644 --- a/sys/src/cmd/aux/na/na.y +++ b/sys/src/cmd/aux/na/na.y @@ -826,7 +826,7 @@ yyerror(char *s, ...) va_start(ap, s); fprintf(stderr, "%s: %d: ", yyfilename, yyline); vfprintf(stderr, s, ap); - if (putc('\n', stderr) < 0) + if (putc('\n', stderr) == EOF) exits("io"); errors++; va_end(ap); @@ -840,7 +840,7 @@ yywarn(char *s, ...) va_start(ap, s); fprintf(stderr, "%s: %d: warning: ", yyfilename, yyline); vfprintf(stderr, s, ap); - if (putc('\n', stderr) < 0) + if (putc('\n', stderr) == EOF) exits("io"); warnings++; va_end(ap); |