diff options
author | cinap_lenrek <cinap_lenrek@felloff.net> | 2014-11-07 12:51:59 +0100 |
---|---|---|
committer | cinap_lenrek <cinap_lenrek@felloff.net> | 2014-11-07 12:51:59 +0100 |
commit | 797cc13c7053dbdd16c20dc4dee5aee8c92390b0 (patch) | |
tree | 5aa7a00f0edeb1d2938d2dff116ee37f2570e8a5 /sys/src/cmd/cpu.c | |
parent | 5364fa720de3b963a88dc4810ed83b4f2ab11d12 (diff) |
fix dangerous werrstr() usages
werrstr() takes a format string as its first argument.
a common error is to pass user controlled string buffers
into werrstr() that might contain format string escapes
causing werrstr() to take bogus arguments from the stack
and crash.
so instead of doing:
werrstr(buf);
we want todo:
werrstr("%s", buf);
or if we have a local ERRMAX sized buffer that we can override:
errstr(buf, sizeof buf);
Diffstat (limited to 'sys/src/cmd/cpu.c')
-rw-r--r-- | sys/src/cmd/cpu.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/src/cmd/cpu.c b/sys/src/cmd/cpu.c index 361f568b2..1bfec1764 100644 --- a/sys/src/cmd/cpu.c +++ b/sys/src/cmd/cpu.c @@ -443,7 +443,7 @@ rexcall(int *fd, char *host, char *service) if(n < 0) return "negotiating aan"; if(*err){ - werrstr(err); + errstr(err, sizeof err); return negstr; } } @@ -460,7 +460,7 @@ rexcall(int *fd, char *host, char *service) if(n < 0) return negstr; if(*err){ - werrstr(err); + errstr(err, sizeof err); return negstr; } |