diff options
| author | cinap_lenrek <cinap_lenrek@felloff.net> | 2020-05-02 17:32:01 +0200 |
|---|---|---|
| committer | cinap_lenrek <cinap_lenrek@felloff.net> | 2020-05-02 17:32:01 +0200 |
| commit | ac88ce4f7f19be1aae1fdf390fa870b4be8dc3f5 (patch) | |
| tree | 47df6acf41dd8d2dc607b89af9d4667935d0c952 /sys/src/cmd/pipefile.c | |
| parent | 7ff6ea0f70307d4b82e6df69eb1310a6e27aa4ad (diff) | |
make bind(2) error handling consistent
The mount() and bind() syscalls return -1 on error,
and the mountid sequence number on success.
The manpage states that the mountid sequence number
is a positive integer, but the kernels implementation
currently uses a unsigned 32-bit integer and does not
guarantee that the mountid will not become negative.
Most code just cares about the error, so test for
the -1 error value only.
Diffstat (limited to 'sys/src/cmd/pipefile.c')
| -rw-r--r-- | sys/src/cmd/pipefile.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/src/cmd/pipefile.c b/sys/src/cmd/pipefile.c index 3c4f4dd75..c803b3f58 100644 --- a/sys/src/cmd/pipefile.c +++ b/sys/src/cmd/pipefile.c @@ -78,9 +78,9 @@ main(int argc, char *argv[]) sysfatal("open %s: %r", file); } - if(bind("#|", TEMP, MREPL) < 0) + if(bind("#|", TEMP, MREPL) == -1) sysfatal("bind pipe %s: %r", TEMP); - if(bind(TEMP "/data", file, MREPL) < 0) + if(bind(TEMP "/data", file, MREPL) == -1) sysfatal("bind %s %s: %r", TEMP "/data", file); fd0 = open(TEMP "/data1", OREAD); |