diff options
| author | cinap_lenrek <cinap_lenrek@felloff.net> | 2016-07-24 02:21:32 +0200 |
|---|---|---|
| committer | cinap_lenrek <cinap_lenrek@felloff.net> | 2016-07-24 02:21:32 +0200 |
| commit | a0d4c5e208405f84076891faaa43235bb2b87fc2 (patch) | |
| tree | 9549cd4cd11c57e3c72d31f4a0424c75b1d5a063 /sys/src/cmd/plumb | |
| parent | a840b597cad282e837560b65dad89aa0cfd4af77 (diff) | |
make error handling in 9p service loops consistent
when we get eof, stop the loop immidiately and do not
rely on the read to eventually return an error.
when convM2S() fails to decode the message, error out
and stop the loop. there is no point in continuing.
Diffstat (limited to 'sys/src/cmd/plumb')
| -rw-r--r-- | sys/src/cmd/plumb/fsys.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/sys/src/cmd/plumb/fsys.c b/sys/src/cmd/plumb/fsys.c index 0a5f6fbdd..d68ea0bc3 100644 --- a/sys/src/cmd/plumb/fsys.c +++ b/sys/src/cmd/plumb/fsys.c @@ -237,10 +237,11 @@ fsysproc(void*) if(buf == nil) error("malloc failed: %r"); qlock(&readlock); - while((n = read9pmsg(srvfd, buf, messagesize)) == 0) - ; - if(n < 0) + n = read9pmsg(srvfd, buf, messagesize); + if(n == 0) threadexitsall("unmounted"); + if(n < 0) + error("mount read: %r"); if(readlock.head == nil) /* no other processes waiting to read; start one */ proccreate(fsysproc, nil, Stack); qunlock(&readlock); |