diff options
| author | cinap_lenrek <cinap_lenrek@felloff.net> | 2020-05-02 17:32:01 +0200 |
|---|---|---|
| committer | cinap_lenrek <cinap_lenrek@felloff.net> | 2020-05-02 17:32:01 +0200 |
| commit | ac88ce4f7f19be1aae1fdf390fa870b4be8dc3f5 (patch) | |
| tree | 47df6acf41dd8d2dc607b89af9d4667935d0c952 /sys/src/cmd/trace.c | |
| parent | 7ff6ea0f70307d4b82e6df69eb1310a6e27aa4ad (diff) | |
make bind(2) error handling consistent
The mount() and bind() syscalls return -1 on error,
and the mountid sequence number on success.
The manpage states that the mountid sequence number
is a positive integer, but the kernels implementation
currently uses a unsigned 32-bit integer and does not
guarantee that the mountid will not become negative.
Most code just cares about the error, so test for
the -1 error value only.
Diffstat (limited to 'sys/src/cmd/trace.c')
| -rw-r--r-- | sys/src/cmd/trace.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/src/cmd/trace.c b/sys/src/cmd/trace.c index 2678b0ff6..ca2ec79c8 100644 --- a/sys/src/cmd/trace.c +++ b/sys/src/cmd/trace.c @@ -584,11 +584,11 @@ drawtrace(void) line[sizeof(line) - 1] = '\0'; rfork(RFNAMEG); - if(mount(wfd, -1, "/mnt/wsys", MREPL, line) < 0) + if(mount(wfd, -1, "/mnt/wsys", MREPL, line) == -1) sysfatal("%s: Cannot mount %s under /mnt/wsys: %r", argv0, line); - if(bind("/mnt/wsys", "/dev", MBEFORE) < 0) + if(bind("/mnt/wsys", "/dev", MBEFORE) == -1) sysfatal("%s: Cannot bind /mnt/wsys in /dev: %r", argv0); |