diff options
author | cinap_lenrek <cinap_lenrek@felloff.net> | 2020-10-18 23:39:07 +0200 |
---|---|---|
committer | cinap_lenrek <cinap_lenrek@felloff.net> | 2020-10-18 23:39:07 +0200 |
commit | a5764f8181d4e13f7e4b93c2565f0663b2fbc436 (patch) | |
tree | 6dbf79b6ddb305e529bab88efa5505ce1eb82bf0 /sys/src/cmd/vnc/auth.c | |
parent | d1604b5f9ce1d64919a8b8313e1db22ebd8d5213 (diff) |
pc, pc64: remove mystery "type" bits in pcicfgrw*raw() (fixes qemu, thanks mischief)
the access functions for pci config space in config mode #1
used to set bit 0 in the register offset if the access was
to a device on any bus different from 0.
it is completely unclear why this was done and i can't find
any documentation on this.
but for sure, this breaks all pci config spacess access to
pci devices behind a bridge on qemu. with -trace pci* it
was discovered that all config space register offsets on
devies behind pci brige where off by one.
on real hardware, setting bit 0 in the offset doesnt appear
to be an issue.
thanks mischief for reporting and providing a qemu demo
configuration to reproduce the problem.
Diffstat (limited to 'sys/src/cmd/vnc/auth.c')
0 files changed, 0 insertions, 0 deletions