summaryrefslogtreecommitdiff
path: root/sys/src
diff options
context:
space:
mode:
authorcinap_lenrek <cinap_lenrek@gmx.de>2013-08-27 19:01:41 +0200
committercinap_lenrek <cinap_lenrek@gmx.de>2013-08-27 19:01:41 +0200
commit12ecb3e568312f881bfcb22bef71d5a00cfab196 (patch)
tree474e271fe28af115b7789dcbb1b0437b1492dd52 /sys/src
parentd76eccaf88ee1e44211eeff52970221abf9f1acc (diff)
usbehci: fix portreset.
Port Reset R/W. 1=Port is in Reset. 0=Port is not in Reset. Default = 0. When software writes a one to this bit (from a zero), the bus reset sequence as defined in the USB Specification Revision 2.0 is started. Software writes a zero to this bit to terminate the bus reset sequence. Software must keep this bit at a one long enough to ensure the reset sequence, as specified in the USB Specification Revision 2.0, completes. Note: when software writes this bit to a one, it must also write a zero to the Port Enable bit. Note that when software writes a zero to this bit there may be a delay before the bit status changes to a zero. The bit status will not read as a zero until after the reset has completed.
Diffstat (limited to 'sys/src')
-rw-r--r--sys/src/9/port/usbehci.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/sys/src/9/port/usbehci.c b/sys/src/9/port/usbehci.c
index dd6ac8820..19732dac6 100644
--- a/sys/src/9/port/usbehci.c
+++ b/sys/src/9/port/usbehci.c
@@ -1690,22 +1690,23 @@ portreset(Hci *hp, int port, int on)
if (opio->sts & Shalted)
iprint("ehci %#p: halted yet trying to reset port\n",
ctlr->capio);
+
*portscp = (*portscp & ~Psenable) | Psreset; /* initiate reset */
- coherence();
+ delay(10);
+ *portscp &= ~Psreset;
/*
* usb 2 spec: reset must finish within 20 ms.
* linux says spec says it can take 50 ms. for hubs.
*/
+ delay(10);
for(i = 0; *portscp & Psreset && i < 10; i++)
delay(10);
if (*portscp & Psreset)
- if(0) iprint("ehci %#p: port %d didn't reset within %d ms; sts %#lux\n",
+ iprint("ehci %#p: port %d didn't reset within %d ms; sts %#lux\n",
ctlr->capio, port, i * 10, *portscp);
- *portscp &= ~Psreset; /* force appearance of reset done */
- coherence();
- delay(10); /* ehci spec: enable within 2 ms. */
+ delay(10); /* ehci spec: enable within 2 ms. */
if((*portscp & Psenable) == 0)
portlend(ctlr, port, "full");